Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move schema extraction logic out of FTLProcessor #2360

Closed
stuartwdouglas opened this issue Aug 14, 2024 · 0 comments · Fixed by #2455
Closed

Move schema extraction logic out of FTLProcessor #2360

stuartwdouglas opened this issue Aug 14, 2024 · 0 comments · Fixed by #2455
Labels
jvm

Comments

@stuartwdouglas
Copy link
Collaborator

This should probably be moved into some kind of SchemaBuilder class that can be easily unit tested, and to simplify the processor code.
@github-actions github-actions bot added the triage Issue needs triaging label Aug 14, 2024
@ftl-robot ftl-robot mentioned this issue Aug 14, 2024
Open
@stuartwdouglas stuartwdouglas changed the title Move schema logic out of FTLProcessor Move schema extraction logic out of FTLProcessor Aug 14, 2024
@gak gak removed the triage Issue needs triaging label Aug 14, 2024
@stuartwdouglas stuartwdouglas added run-all A PR with this label will run the full set of CI jobs in the PR rather than in the merge queue and removed run-all A PR with this label will run the full set of CI jobs in the PR rather than in the merge queue labels Aug 20, 2024
stuartwdouglas added a commit that referenced this issue Aug 20, 2024
@stuartwdouglas
chore: move type building logic out of FTLProcessor
6ddaf16 
fixes #2360
@stuartwdouglas stuartwdouglas mentioned this issue Aug 20, 2024
Merged
stuartwdouglas added a commit that referenced this issue Aug 20, 2024
@stuartwdouglas
chore: move type building logic out of FTLProcessor
ab3810f 
fixes #2360
stuartwdouglas added a commit that referenced this issue Aug 20, 2024
@stuartwdouglas
chore: move type building logic out of FTLProcessor
839bea4 
fixes #2360
github-merge-queue bot pushed a commit that referenced this issue Aug 20, 2024
@stuartwdouglas
chore: move type building logic out of FTLProcessor (#2455)
03d4b67 
fixes #2360
@ftl-robot ftl-robot mentioned this issue Aug 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
jvm
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: move type building logic out of FTLProcessor TBD54566975/ftl
2 participants
@gak @stuartwdouglas