Disallow json.(Un)Marshaler/encoding.Text(Un)Marshaler on user-defined types
#1247
Assignees
Labels
Comments
alecthomas
added
the
intermediate
Open
alecthomas
added
techdebt
deniseli
added a commit
that referenced
this issue
May 7, 2024
This PR: * Rips out the existing textMarshaler and jsonMarshaler usage from encoding.go. We may want to add those back for #1296 down the road, but we will need to be thoughtful about how we do that. Removing it for now keeps the logic much more predictable. * Moves the (un)marshaling logic for `ftl.Option` out of `option.go` and into `encoding.go`. * Special-cases both `time.Time` (the only stdlib type we currently support) and `ftl.Option`. Also `json.RawMessage` for _just_ encoding to preserve the existing `omitempty` behavior. * Fixes some existing issues where the Pointer unmarshaling wasn't actually working correctly * [eww] Adds a rather grotesque alternative to `Peek()` in `isNextTokenNull()` because json Decoder does not support Peek. * [eww] Makes the ftl.Option struct fields public so that they are settable by `encoding.go`. Suggestions welcome for both counts of [eww] above :) Fixes #1247. Addresses most of #1262, except `omitempty` is only working for json.RawMessage for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We added support for delegating to
json.(Un)Marshaler/encoding.Text(Un)Marshaleronly so that stdlib types such astime.Timewould be correctly transcoded. Something I didn't think of at the time though, is that this would allow user types to override encoding, which is something that we do not want.The text was updated successfully, but these errors were encountered: