Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log when we don't deploy because code is unchanged #1228

Closed
worstell opened this issue Apr 10, 2024 · 0 comments · Fixed by #1266
Closed

log when we don't deploy because code is unchanged #1228

worstell opened this issue Apr 10, 2024 · 0 comments · Fixed by #1266
Assignees
@wesbillman
Labels
good first issue Good for newcomers

Comments

@worstell
Copy link
Contributor

when a module's source code is reverted to a previously deployed state, no new deploy artifacts are created - the messaging in this scenario is confusing and ftl appears to hang (even though it isn't). we should improve messaging here
@github-actions github-actions bot added the triage Issue needs triaging label Apr 10, 2024
@alecthomas alecthomas mentioned this issue Apr 10, 2024
Open
@worstell worstell added the good first issue Good for newcomers label Apr 10, 2024
@matt2e matt2e added next Work that will be be picked up next and removed triage Issue needs triaging labels Apr 11, 2024
@github-actions github-actions bot removed the next Work that will be be picked up next label Apr 12, 2024
@wesbillman wesbillman mentioned this issue Apr 15, 2024
Merged
wesbillman added a commit that referenced this issue Apr 15, 2024
@wesbillman
chore: improve logging when deployment is reused (#1266)
5c9ddce 
Fixes #1228 
![Screenshot 2024-04-15 at 2 36
42 PM](https://github.com/TBD54566975/ftl/assets/51647/82d32fa2-7eb2-4c68-9fda-f361d53eb9df)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wesbillman wesbillman

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: improve logging when deployment is reused TBD54566975/ftl
3 participants
@wesbillman @matt2e @worstell