Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FTL console does not re-populate module that is stopped then redeployed during ftl dev #1200

Closed
mistermoe opened this issue Apr 8, 2024 · 1 comment · Fixed by #1204
Closed

FTL console does not re-populate module that is stopped then redeployed during ftl dev #1200

mistermoe opened this issue Apr 8, 2024 · 1 comment · Fixed by #1204
Assignees
@wesbillman

Comments

@mistermoe
Copy link
Member

ftlbug3.mov
@github-actions github-actions bot added the triage Issue needs triaging label Apr 8, 2024
@alecthomas alecthomas mentioned this issue Apr 8, 2024
Open
@wesbillman wesbillman self-assigned this Apr 8, 2024
@github-actions github-actions bot removed the triage Issue needs triaging label Apr 8, 2024
@wesbillman
Copy link
Member

I think this issue was introduced here: https://github.com/TBD54566975/ftl/pull/1172/files#diff-a0c459862b79adf4314734937ce8e1e95f29f39932687ee3e879fff6e6bb214c

Because of the way the schema changes and deployments work, when we detect a schema change in the db, it will have been caused by a deployment record being created or updated. However, at this time the runners might not have reconciled. So we'll have a deployment with min_replicas > 0 but no runner assigned yet. And because we use PullSchema to detect when changes have occurred this results in only deployments which have fully reconciled being returned.

I'll make a PR with a new dal method to get deployments with replicas, but we might want to discuss if that is the best approach here as well.

@wesbillman wesbillman mentioned this issue Apr 8, 2024
Merged
wesbillman added a commit that referenced this issue Apr 9, 2024
@wesbillman
fix: add query for getting deployments with replicas (#1204)
2424f2c 
Fixes #1200 

This introduces a new query to get deployments with `min_replicas > 0`.
We could also modify some other existing queries if that's preferred.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wesbillman wesbillman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add query for getting deployments with replicas TBD54566975/ftl
2 participants
@wesbillman @mistermoe