Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ftl dev --background-after-deploy or alter existing --background to have this behaviour #1168

Open
alecthomas opened this issue Apr 4, 2024 · 3 comments
Labels
good first issue Good for newcomers

Comments

@alecthomas
Copy link
Collaborator

This is typically what I want to do in shell scripts eg.

ftl dev --background-after-deploy .
trap "ftl dev --stop --no-serve" EXIT ERR SIGINT
ftl call foo.bar
@alecthomas alecthomas added the good first issue Good for newcomers label Apr 4, 2024
@wesbillman
Copy link
Member

It's an extra command, but we can use serve as well.

ftl serve --background
trap "ftl serve --stop" EXIT ERR SIGINT
ftl deploy .
ftl call foo.bar

@alecthomas
Copy link
Collaborator Author

We're getting rid of serves though IIRC

@stuartwdouglas stuartwdouglas self-assigned this Jul 24, 2024
@ftl-robot ftl-robot mentioned this issue Jul 24, 2024
@stuartwdouglas
Copy link
Collaborator

I had a look at this, and it needs some way for the background process to signify that it is done deploying to the outer process that launched it. I don't think we want to open a socket or declare a new service just for this, so I am not really sure what the best approach is here. Maybe an extra field on the controller status to indicate that all initial dev deployments are done, but that also feels a bit yuck.

@stuartwdouglas stuartwdouglas removed their assignment Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants