Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to handle errors from any language runtime #1159

Closed
Tracked by #1122
wesbillman opened this issue Apr 2, 2024 · 0 comments · Fixed by #1180
Closed
Tracked by #1122

Ability to handle errors from any language runtime #1159

wesbillman opened this issue Apr 2, 2024 · 0 comments · Fixed by #1180
Assignees
@worstell

Comments

@wesbillman
Copy link
Member

wesbillman commented Apr 2, 2024 •
edited
Loading

Ideas: For handling errors from all language runtimes

  • Create GRPC server and runtimes push errors back as they build
  • Come up with some protocol that we can use to talk with builds over stderr
    output json and that json has the structured errors in them
    probably the easiest approach
@wesbillman wesbillman mentioned this issue Apr 2, 2024
Closed
5 tasks
@github-actions github-actions bot added the triage Issue needs triaging label Apr 2, 2024
@github-actions github-actions bot removed the triage Issue needs triaging label Apr 2, 2024
@alecthomas alecthomas mentioned this issue Apr 2, 2024
Open
@wesbillman wesbillman changed the title Ability to handle errors from any language runtime (current approach only works for go, see below for ideas) Ability to handle errors from any language runtime Apr 2, 2024
worstell added a commit that referenced this issue Apr 4, 2024
@worstell
feat: pass kotlin build errors to the language server
c3b1e5d 
fixes #1123
fixes #1159
worstell added a commit that referenced this issue Apr 4, 2024
@worstell
feat: pass kotlin build errors to the language server
2d64bfd 
fixes #1123
fixes #1159
worstell added a commit that referenced this issue Apr 5, 2024
@worstell
feat: pass kotlin build errors to the language server
a9b24d5 
fixes #1123
fixes #1159
worstell added a commit that referenced this issue Apr 5, 2024
@worstell
feat: pass kotlin build errors to the language server
241e039 
fixes #1123
fixes #1159
@worstell worstell mentioned this issue Apr 5, 2024
Merged
worstell added a commit that referenced this issue Apr 5, 2024
@worstell
feat: pass kotlin build errors to the language server
bd851bb 
fixes #1123
fixes #1159
worstell added a commit that referenced this issue Apr 5, 2024
@worstell
feat: pass kotlin build errors to the language server (#1180)
f0006fa 
although we've temporarily suspended development on the kotlin runtime,
this was a useful proof-of-concept to demonstrate how we can build
non-Go runtimes to interact with the language server

fixes #1123
fixes #1159


<img width="1436" alt="Screenshot 2024-04-04 at 3 23 15 PM"
src="https://github.com/TBD54566975/ftl/assets/72891690/a8cb7605-08bf-4b44-a819-239c08ddfa3f">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@worstell worstell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: pass kotlin build errors to the language server TBD54566975/ftl
2 participants
@wesbillman @worstell