Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse out error location in file to only highlight the word reported by FTL #1158

Closed
Tracked by #1122
wesbillman opened this issue Apr 2, 2024 · 1 comment · Fixed by #1177
Closed
Tracked by #1122

Parse out error location in file to only highlight the word reported by FTL #1158

wesbillman opened this issue Apr 2, 2024 · 1 comment · Fixed by #1177
Assignees

Comments

@wesbillman
Copy link
Member

wesbillman commented Apr 2, 2024

There's a basic implementation in main now, but we should update it to be more efficient and robust. The basic version implemented in lsp should only be used if we don't get EndColumn information from the solutions below.

There are likely 2 options here.

  1. Add an EndColumn field to schema.Position and update as needed
  2. Add EndColumn to custom Error struct
@github-actions github-actions bot added the triage Issue needs triaging label Apr 2, 2024
@alecthomas alecthomas mentioned this issue Apr 2, 2024
@wesbillman wesbillman self-assigned this Apr 2, 2024
@github-actions github-actions bot removed the triage Issue needs triaging label Apr 2, 2024
@wesbillman
Copy link
Member Author

We decided on using a custom error type for this and generating protos for that error type so that other runtimes can have a consistent interface for these errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant