Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run autofmt on main instead of PR #1075

Closed
alecthomas opened this issue Mar 13, 2024 · 1 comment
Closed

Run autofmt on main instead of PR #1075

alecthomas opened this issue Mar 13, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@alecthomas
Copy link
Collaborator

When it's run on a PR, GitHub status reporting fails to work at all. I think what happens is that, the autofmt becomes the latest commit on the PR and status reporting switches to that commit, but because one action can't trigger another indirectly, the normal CI steps don't retrigger on the new commit, leaving them as zombies on the main PR commit.

@alecthomas alecthomas changed the title Run autofmt on main Run autofmt on main instead of PR Mar 13, 2024
@github-actions github-actions bot added the triage Issue needs triaging label Mar 13, 2024
@michaelneale michaelneale self-assigned this Mar 28, 2024
@michaelneale
Copy link
Contributor

#1145 fixes this

@github-actions github-actions bot removed the triage Issue needs triaging label Mar 28, 2024
@michaelneale michaelneale added the bug Something isn't working label Mar 28, 2024
wesbillman pushed a commit that referenced this issue Apr 2, 2024
for issue: #1075

Not sure of best way to test - I may try it on another branch perhaps? 

edit: tested it by having it push to this branch as if it was main, and
it did what I expected. Doesn't need the FTL_AUTOFIX_TOKEN anymore, and
won't trigger a rebuild (flip side of that is if it does have a rebuild,
there won't be a build run against it - is that suitable @alecthomas ?)

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants