Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up error position handling in go-runtime/schema #1062

Closed
alecthomas opened this issue Mar 12, 2024 · 1 comment · Fixed by #1064
Closed

Clean up error position handling in go-runtime/schema #1062

alecthomas opened this issue Mar 12, 2024 · 1 comment · Fixed by #1064
Assignees
@alecthomas
Labels
good first issue Good for newcomers

Comments

@alecthomas
Copy link
Collaborator

Currently the position is added as a prefix to the error willy nilly, often ending up with multiple positions stacked in the message. Introduce a custom error type that includes a position, and wrapping function that only adds a position if there isn't already one.
@github-actions github-actions bot added the triage Issue needs triaging label Mar 12, 2024
@alecthomas alecthomas added good first issue Good for newcomers triage Issue needs triaging and removed triage Issue needs triaging labels Mar 12, 2024
@alecthomas alecthomas self-assigned this Mar 12, 2024
@github-actions github-actions bot removed the triage Issue needs triaging label Mar 12, 2024
@alecthomas
Copy link
Collaborator Author

Going to take this one as it's super annoying.

This was referenced Mar 12, 2024
Open
Merged
alecthomas added a commit that referenced this issue Mar 12, 2024
@alecthomas
fix(go-runtime): remove duplicate positional information in errors (#…
4221f57 
…1064)

Fixes #1062
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alecthomas alecthomas

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(go-runtime): remove duplicate positional information in errors TBD54566975/ftl
1 participant
@alecthomas