Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tapis apps deploy fails with 404 for new Designsafe accounts. #360

Open
bpachev opened this issue Jun 8, 2021 · 0 comments · May be fixed by #359
Open

tapis apps deploy fails with 404 for new Designsafe accounts. #360

bpachev opened this issue Jun 8, 2021 · 0 comments · May be fixed by #359

Comments

@bpachev
Copy link

bpachev commented Jun 8, 2021

Describe the bug
Under certain conditions (typically new users deploying their first application), tapis apps deploy fails with a 404 unless --no-upload is specified.

To Reproduce
Steps to reproduce the behavior:

  1. Create a new DesignSafe Account (or temporarily rename the apps directory)
  2. Run tapis auth init --interactive and choose designsafe
  3. Clone https://github.com/cdelcastillo21/tapisv2_apps and cd tapisv2_apps/test_app
  4. tapis apps deploy

Expected behavior
A message similar to the one below
[Errno 404] Not Found for https://agave.designsafe-ci.org/files/v2/media/system/designsafe.storage.default//bpachev/apps/assets-2021-06-07: 'No such file or directory'

After some time digging around the source code, I discovered the issue was because I didn't have an apps directory on my DesignSafe account - and the code did not handle the case when multiple directories on deployPath don't exist. I created a simple, minimal PR that resolved the issue I ran into - #359.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant