Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch/make environment type configurable #168

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

taoteg
Copy link
Contributor

@taoteg taoteg commented Nov 15, 2023

Overview:

A small QoL tweak to avoid committing incorrect backend environment during development.

PR Status:

  • Ready.
  • Work in Progress.
  • Hold.

Related Jira tickets:

  • None

Summary of Changes:

Changed the assignment of the angular client backend to use a constant exported form the jwt.ts file.

Testing Steps:

  1. Add these lines to your /hazmapper/angular/src/environments/jwt.ts file:
import { EnvironmentType } from '../environments/environmentType';
export const dev_env = EnvironmentType.Staging;      # Local, Staging, Production
  1. Run the project using the correct start command (npm run start or npm run start:locally if set to Local).
  2. Open browser to project URL (localhost:4200 or hazmapper.local:4200) and use.

UI Photos:

Notes:

nathanfranklin and others added 3 commits October 26, 2023 16:26
* Do not show _hazmapper properties

* Add ng-bootstrap to use carousel

* Add carasol to show questionnaire assets

* User correct version of npm so lock file doesn't change

* Switch CI to match our container's version of node

* Refactor into a component

* Remove bootstrap

* Use own-carousel for image asset carousel

* Fix linting

* Remove unintended blank line

* Revert "Switch CI to match our container's version of node"

This reverts commit 357027a.

* Fix weird formatting issues

* Revert "Revert "Switch CI to match our container's version of node""

This reverts commit 4077c5a.
…165)

* Show asset images with questions

* Fix prettier errors

* Remove reduntant types from JSDoc strings
@taoteg taoteg marked this pull request as draft November 15, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants