Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add progress spinner to organigram and room #700

Open
friedaxvictoria opened this issue May 22, 2020 · 2 comments
Open

Add progress spinner to organigram and room #700

friedaxvictoria opened this issue May 22, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@friedaxvictoria
Copy link
Contributor

Same solution as in #674

@friedaxvictoria friedaxvictoria added the bug Something isn't working label May 22, 2020
@paule96
Copy link
Collaborator

paule96 commented May 23, 2020

and also for rooms please :) @DanielHabenicht can we just add an interceptor that runs before every xhr request and after? That's maybe simpler to catch everything. And don't display the spinner in the table. Just gray out the app and show a spinner on top of the app?

@DanielHabenicht DanielHabenicht changed the title Add progress spinner to organigram Add progress spinner to organigram and room May 25, 2020
@DanielHabenicht
Copy link
Collaborator

You could but thats not really user friendly because you could have clicked wrong and just want to click another navigation button right away.

Of course, there could be a generalized component for loading and error handling, but for now, it might be easier to just copy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants