Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrumenting metrics? #20

Open
kjersti opened this issue Nov 12, 2019 · 3 comments
Open

Instrumenting metrics? #20

kjersti opened this issue Nov 12, 2019 · 3 comments
Labels
enhancement New feature or request
Milestone

Comments

@kjersti
Copy link

kjersti commented Nov 12, 2019

I am looking to instrument our router instance with some metrics. I was able to get a hook into the prerouting context using a Rule. Is there something similar for failures?

@SzymonPobiega
Copy link
Owner

Hi

No. There is no hook in the failure handling. What kinds of events would be interesting for you?

@kjersti
Copy link
Author

kjersti commented Nov 12, 2019

Initially, I wanted a counter for errors, as well as the counter for incoming messages. I was able to configure a gauge metrics by implementing a module that queries the poison queue on a regular interval, but I'm not sure if this is the best way to implement it.

If you have any ideas or comments, I am open to that. I am willing to help with the work if needed.

Btw, this tool is great, very helpful for us in a phase where we are transitioning from one transport to another. Thanks! :)

@SzymonPobiega SzymonPobiega added this to the 4.0.0 milestone Mar 27, 2020
@SzymonPobiega SzymonPobiega added the enhancement New feature or request label Aug 17, 2020
@SzymonPobiega
Copy link
Owner

Hi @kjersti . I did some research and it seems that EventCounters are the way to implement such things. I will be working on adding the counters to the router. My ideas for counters are following:

  • Message processing time end-to-end (per each interface)
  • Number of messages processed
  • Number of retries
  • Number of messages moved to poison queue

Do you have any other ideas for counters that could be useful?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants