Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files with multiple extensions seem to cause problems. #50

Open
roddypratt opened this issue Jan 11, 2024 · 3 comments
Open

Files with multiple extensions seem to cause problems. #50

roddypratt opened this issue Jan 11, 2024 · 3 comments
Labels
bug Something isn't working vscode The issue is related to our VS Code extension

Comments

@roddypratt
Copy link

Using semanticdiff with file "myfile.json" works correctly, but with "my.file.json" I get an error message:

"This type of diff is not supported by SemanticDiff."

@roddypratt roddypratt added the bug Something isn't working label Jan 11, 2024
@mmueller2012
Copy link
Contributor

The error message is unrelated to the used programming language or file extension. When the SemanticDiff command is invoked, the extension tries to find the currently active editor tab and checks if it belongs to the VS Code diff viewer. If the extension cannot find the diff viewer, this error message is displayed.

My guess: Are you trying to use SemanticDiff with the merge view instead? We don't support 3-way comparison / merging yet.

@roddypratt
Copy link
Author

roddypratt commented Jan 11, 2024

Thanks. I'm just using it via the vscode git integration to view changes before commit. Screencapture video here. https://screenpal.com/watch/cZVXFqVJcmn

I created a simple file with a .foo.json extension, and that worked fine. It's just this 'other' file that seems to be a problem. Wierd!

@mmueller2012
Copy link
Contributor

This is really odd. I tried my best to reproduce it, but it works for me (see the video).

test-vscode.-.Visual.Studio.Code.2024-01-11.21-04-31.mp4

I think we need some more information to narrow this down:

  • Does it work if you manually invoke the command when the diff view is open (press CTRL + SHIFT + P, search for "Switch to SemanticDiff" and press enter)?

  • What version of VS Code do you use (just copy the information in Help -> About)?

  • Do you have any other extensions installed that are related to this file format or diffs in general?

@mmueller2012 mmueller2012 added the vscode The issue is related to our VS Code extension label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working vscode The issue is related to our VS Code extension
Projects
None yet
Development

No branches or pull requests

2 participants