New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solc compilateion may result in error that is not accounted for #2

Open

noisekit opened this issue Jun 21, 2023 · 0 comments

Collaborator

noisekit commented Jun 21, 2023

synthetix-router/src/compile.ts

Line 27 in 35a629c

return solResult.contracts[`${contractName}.sol`][contractName];

solResult may come with error and we are not catching it

solResult {
  errors: [
    {
      component: 'general',
      formattedMessage: 'Invalid EVM version requested.',
      message: 'Invalid EVM version requested.',
      severity: 'error',
      type: 'JSONError'
    }
  ]
}

Instead it fails with

An unexpected error occurred:

TypeError: Cannot read properties of undefined (reading 'AccountRouter.sol')
    at compileContract (/node_modules/@synthetixio/router/src/compile.ts:22:1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment