Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing problem on LineItem entity #206

Open
jorisduenas opened this issue Feb 8, 2021 · 1 comment
Open

Typing problem on LineItem entity #206

jorisduenas opened this issue Feb 8, 2021 · 1 comment

Comments

@jorisduenas
Copy link

Hi,

I noticed a problem on LineItem objects. In the class we find getId() and id() which return a string like this:

LineItem.php#L62

public function getId(): string
{
    return $this->id();
}

public function id(): string
{
    return $this->id;
}

However, this id is configured as integer in the orm:

LineItem.orm.xml#L5

<id name="id" column="id" type="integer">
    <generator strategy="AUTO" />
</id>

This creates typing errors.

@diimpp
Copy link
Member

diimpp commented Feb 10, 2021

And it should be nullable as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants