Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change OrderPaymentPaid event to OrderPaid #142

Open
diimpp opened this issue Jun 9, 2019 · 0 comments
Open

Change OrderPaymentPaid event to OrderPaid #142

diimpp opened this issue Jun 9, 2019 · 0 comments
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).

Comments

@diimpp
Copy link
Member

diimpp commented Jun 9, 2019

There is case, when Order may have multiple valid payments with partial amounts, which sums up to Order total. (At least vanilla Sylius supports such behaviour with Order:paymentState->partially_paid and I personally have multi-payment case in one of my projects), so only Order:paymentState should be used to determine, if order is paid, not Payment:state.
@Zales0123 Zales0123 added the Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). label Jun 10, 2019
@diimpp diimpp mentioned this issue Feb 20, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@diimpp @Zales0123