Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Payload length field of V2G-TP is interpreted as signed integer instead of unsigned #65

Open
geynis opened this issue May 25, 2021 · 0 comments
Open

Payload length field of V2G-TP is interpreted as signed integer instead of unsigned #65

geynis opened this issue May 25, 2021 · 0 comments

Comments

@geynis
Copy link

geynis commented May 25, 2021

The payload length field of V2G-TP is interpreted as signed integer instead of unsigned, so test like:

if (getPayloadLength() > 10000 )

will not catch cases when the value is larger than 0x7FFFFFFF, this will result later in an exception trying to create an array with negative length.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@geynis