Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: consolidate network policies #3839

Merged
merged 18 commits into from
Nov 22, 2024
Merged
Show file tree
Hide file tree
Changes from 14 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 23 additions & 10 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,28 @@
Renku 0.61.0 introduces a new version of Amalthea that supports running sessions with Docker images
that do not contain Jupyter server.

NOTE to administrators: This upgrade introduces a brand new CRD for sessions. All services that support
sessions for Renku v2 will switch to this new CRD. Renku v1 sessions remain unchanged.
Therefore any old sessions for Renku v2 will not be visible to users after this upgrade. The sessions
themselves will not be immediately deleted and as long as users have saved links to their old sessions they
should be able to access their sessions and save data. However we recommend that administrators
notify users of the change and allow for enough time so that existing Renku v2 sessions can be saved and
cleaned up, rather than asking users to save the url to their sessions. In addition to users not being able
to see old Renku v2 sessions, they will also not be able to pause, resume or delete old Renku v2 sessions.
Therefore it's best if most sessions are properly saved and cleaned up before this update is rolled out. In order
to support the new CRD we have also created a new operator that will manage the new `amaltheasession` resources.
NOTES to administrators:

- This upgrade introduces a brand new CRD for sessions. All services that support
sessions for Renku v2 will switch to this new CRD. Renku v1 sessions remain unchanged.
Therefore any old sessions for Renku v2 will not be visible to users after this upgrade. The sessions
themselves will not be immediately deleted and as long as users have saved links to their old sessions they
should be able to access their sessions and save data. However we recommend that administrators
notify users of the change and allow for enough time so that existing Renku v2 sessions can be saved and
cleaned up, rather than asking users to save the url to their sessions. In addition to users not being able
to see old Renku v2 sessions, they will also not be able to pause, resume or delete old Renku v2 sessions.
Therefore it's best if most sessions are properly saved and cleaned up before this update is rolled out. In order
to support the new CRD we have also created a new operator that will manage the new `amaltheasession` resources.

- The network policies for Renku have been consolidated and revamped. The most notable change here is the
removal of the egress policy that prevented egress to internal IP addresses from sessions. Now we disallow
all ingress in the Renku release namespace by default and explicitly grant permissions to any pods that need
to access other pods inside the Renku release namespace. Two properties relevant to this have been added to the
Helm chart values file that allows administrators to grant access to all Renku services from a specific namespace
or to do the same for specific pods within the Renku namespace. These are not needed for Renku to function and the
default network policies should be sufficient, they have been added so that administrators can allow ingress for
other services that may not come with the Renku Helm chart such as logging or monitoring. This change will result in
the removal of some network policies and the creation of several new policies.

User-Facing Changes
~~~~~~~~~~~~~~~~~~~
Expand All @@ -33,6 +45,7 @@ Internal Changes

- **Data services**: Add support for OAuth storage providers
- **Data services**: Move notebooks code to data services
- **Helm chart**: Consolidate and revamp network policies

**Bug Fixes**

Expand Down
3 changes: 3 additions & 0 deletions helm-chart/renku/templates/core/cache-cleanup-job.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ spec:
jobTemplate:
spec:
template:
metadata:
labels:
app: core-cache-cleanup
spec:
containers:
- name: {{ include "renku-core.fullname" $ }}-cache-cleanup-{{ $version.name }}
Expand Down
Loading
Loading