Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: consolidate network policies #3839

Merged
merged 18 commits into from
Nov 22, 2024

Conversation

olevski
Copy link
Member

@olevski olevski commented Nov 20, 2024

/deploy extra-values=networkPolicies.allowAllIngressFromNamespaces={default},networkPolicies.allowAllIngressFromPods[0].podSelector.matchLabels.app=allowAllIngress

@RenkuBot
Copy link
Collaborator

You can access the deployment of this PR at https://ci-renku-3839.dev.renku.ch

Copy link
Member

@Panaetius Panaetius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still the setup-job-network-policy, not sure if you wanted to move that as well?

@olevski
Copy link
Member Author

olevski commented Nov 21, 2024

There's still the setup-job-network-policy, not sure if you wanted to move that as well?

I left that one on purpose. Because it already sits there near all the rest of the setup job helm temoplates.

EDIT: @Panaetius I will actually clean that up as well. I looked at it earlier but did not notice that it opens the metrics port to postgres for everyone. That is not the end of the world but the metrics port on postgres being open to all pods has nothing to do with the setup jobs. So I will just move this as well.

@olevski
Copy link
Member Author

olevski commented Nov 22, 2024

@aledegano @Panaetius this is ready.

@olevski olevski merged commit 5a76f66 into release-0.61.0 Nov 22, 2024
20 checks passed
@olevski olevski deleted the fix-network-policy-consolidate branch November 22, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants