Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: jupyter free sessions in Renku v2 #3712

Merged
merged 49 commits into from
Nov 19, 2024

Conversation

olevski
Copy link
Member

@olevski olevski commented Jul 15, 2024

Jupyter free sessions

/deploy extra-values=amalthea-sessions.deployCrd=false

@olevski olevski requested review from a team as code owners July 15, 2024 11:58
@olevski olevski changed the base branch from master to release-0.55.0 July 15, 2024 11:59
@olevski olevski changed the base branch from release-0.55.0 to release-0.57.0 August 12, 2024 14:53
@olevski olevski marked this pull request as ready for review November 13, 2024 14:09
@olevski olevski requested review from a team as code owners November 13, 2024 14:09
CHANGELOG.rst Outdated Show resolved Hide resolved
CHANGELOG.rst Outdated Show resolved Hide resolved
CHANGELOG.rst Outdated Show resolved Hide resolved
CHANGELOG.rst Outdated Show resolved Hide resolved
Copy link
Member

@leafty leafty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Authproxy is broken for anon sessions.

@olevski
Copy link
Member Author

olevski commented Nov 18, 2024

Authproxy is broken for anon sessions.

@leafty thatnks for catching that. This small RP fixes the issue: SwissDataScienceCenter/amalthea#768

I forgot to make the authentication middleware act only on the proxy routes - it was acting also on the healthcheck.

@olevski olevski merged commit b445253 into release-0.61.0 Nov 19, 2024
18 checks passed
@olevski olevski deleted the feat-jupyter-free-sessions branch November 19, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants