feat(helm): Make Jena passwords optional in values file. #3389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit continues on the topic of making the definition of the secrets in the values files optional, to simplify CI deployments. As previous similar commits this change supports: - Existing deployments where the secret is defined will keep working as usual - New deployments where the secret is defined will keep working as they did before this change - New deployments where the secret is NOT defined will get 2 random passwords which will be persisted across upgrades/redeployments The three scenarios have been manually tested.
aledegano
temporarily deployed
to
ci-renku-3389
GitHub Actions
Inactive
aledegano
temporarily deployed
to
ci-renku-3389
GitHub Actions
Inactive
aledegano
temporarily deployed
to
ci-renku-3389
GitHub Actions
Inactive
|
@aledegano can we get this either merged or closed? Should be rebased on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit continues on the topic of making the definition of the secrets in the values files optional, to simplify CI deployments.
As previous similar commits this change supports:
Existing deployments where the secret is defined will keep working as usual
New deployments where the secret is defined will keep working as they did before this change
New deployments where the secret is NOT defined will get 2 random passwords which will be persisted across upgrades/redeployments
The three scenarios have been manually tested.
This PR doesn't change anything to users or admins, therefore I didn't write an entry in the changelog to avoid unnecessary noise, let me know if you would rather have one.