Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taging all the init images #3784

Closed
JGodin-C2C opened this issue Sep 26, 2024 · 3 comments
Closed

Taging all the init images #3784

JGodin-C2C opened this issue Sep 26, 2024 · 3 comments
Labels
kind/bug status/triage Issue needs to be triaged

Comments

@JGodin-C2C
Copy link
Contributor

JGodin-C2C commented Sep 26, 2024

Latest used in init images tags

Hello all !

I wanted to bring to your attention the fact that the init images are by default using the latest tag.
I dont think this is a good idea as sometimes latest is 3 year old.
For exemple
https://hub.docker.com/r/renku/init-realm/tags?name=latest
While sometimes they simply does not exists
https://hub.docker.com/r/renku/init-db/tags?name=latest

( The latest tag not existing is preferable IMHO )
This forces us to inject those values.

Expected behavior
A sane tag is used to identify the init images

Screenshots and/or execution output
At the moment , i already found these values that are setted to latest :

https://github.com/SwissDataScienceCenter/renku/blob/master/helm-chart/renku/values.yaml#L322
https://github.com/SwissDataScienceCenter/renku/blob/master/helm-chart/renku/values.yaml#L1589
https://github.com/SwissDataScienceCenter/renku/blob/master/helm-chart/renku/values.yaml#L1594

Regards
J\x00

@JGodin-C2C JGodin-C2C added kind/bug status/triage Issue needs to be triaged labels Sep 26, 2024
@olevski
Copy link
Member

olevski commented Oct 10, 2024

@JGodin-C2C these are updated by chartpress when we publish our helm charts. So if you look at any published helm chart you will see that the default values in the values file are specific tags that match the renku release. Not latest.

For example if you download 0.57.0 from here:
https://github.com/SwissDataScienceCenter/helm-charts/blob/gh-pages/renku-0.57.0.tgz

And extract the contents and check the values file you will see:

...
## keycloak admin username/password is supplied.
  initRealm:
    image:
      repository: renku/init-realm
      tag: "0.57.0"
...
## The image used in startup scripts to initialize different postgress databases
initDb:
  image:
    repository: renku/init-db
    tag: "0.57.0"
## The image used for general platform initialization
platformInit:
  image:
    repository: renku/platform-init
    tag: "0.57.0"
...

The only time the "latest" versions would be used is if someone tries to deploy renku from the helm chart code in the renku repo - and not from a published version. Anyhow we can publish the "latest" images so that things work even in this case. If we wanted to tag these with a specific version we would have a bit of a problem because at the time of tagging the images would not be around. I.e. if we tagged these to 0.60.0 before 0.60.0 is released then the 0.60.0 images would not be around. And I would rather not complicate things to have to tag right after every release is done or to have a step in the release process that just builds the images and then stops and waits for us to upgrade the values file and then we continue with the helm chart publishing. Chartpress fixes exactly this problem and will always set the values in the values file to the right version. But to be safe we can also publish "latest" on every release.

@JGodin-C2C
Copy link
Contributor Author

JGodin-C2C commented Oct 11, 2024

@olevski
That´s odd.
I tar -zxvf the downloaded chart and the tags are now okay.
I may have mixed myself somewhere.
Sorry for the noise and thanks for the answer.

@JGodin-C2C
Copy link
Contributor Author

Cannot reproduce .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug status/triage Issue needs to be triaged
Projects
None yet
Development

No branches or pull requests

2 participants