Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not mount secrets as environment variables #2685

Open
olevski opened this issue Aug 31, 2022 · 0 comments
Open

Do not mount secrets as environment variables #2685

olevski opened this issue Aug 31, 2022 · 0 comments

Comments

@olevski
Copy link
Member

olevski commented Aug 31, 2022

Feedback from the security engineers at BIT.

It is better to mount secrets as volumes because sometimes logs dump all environment variables, so it is more risky that secrets will leak to logs if mounted as environment vars.

This requires two steps:

  • see which services do this
  • propose and quickly test a solution and open a new issue (if required)

It could be that mounting secrets as volumes also prevents a service from properly restarting and using the new values if the secret changes. Not sure exactly if mounting secrets as environment variables helps in this case too tbh.

@olevski olevski moved this to Backlog in renku-python Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

1 participant