Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for metamask's privacy mode #172

Open
Powersource opened this issue Oct 17, 2018 · 5 comments · May be fixed by #215
Open

Add support for metamask's privacy mode #172

Powersource opened this issue Oct 17, 2018 · 5 comments · May be fixed by #215
Assignees
@Powersource
Labels
blocked issues that currently can't progress due to waiting on some other issue/process priority: high

Comments

@Powersource
Copy link
Member

This article describes it pretty well https://medium.com/metamask/https-medium-com-metamask-breaking-change-injecting-web3-7722797916a8
it talks about it from the perspective of websites, but I think it applies to us too.

Doesn't seem like major changes are needed (hopefully just a few lines) but either way, we need to fix this before the deadline.
@Powersource
Copy link
Member Author

Ok not as simple as I thought, the metamask developers might have forgotten to implement this for connections from other browser extensions. Thankfully the privacy option is opt-in for now. We should file an issue and hope it gets fixed before it turns opt-out.

@Powersource Powersource self-assigned this Dec 19, 2018
@Powersource
Copy link
Member Author

Submitted an issue here MetaMask/metamask-extension#5950

@Powersource Powersource changed the title Prepare for the metamask breaking change on nov 2nd Add support for metamask's privacy mode Dec 20, 2018
@Powersource Powersource added the blocked issues that currently can't progress due to waiting on some other issue/process label Dec 20, 2018
@ErikBjare
Copy link
Member

Also discussed here: MetaMask/extension-provider#3

@ErikBjare
Copy link
Member

Temporary workaround issue: #200

@Powersource
Copy link
Member Author

Maybe better workaround MetaMask/metamask-extension#5950 (comment)

@Powersource Powersource linked a pull request Jul 12, 2019 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Powersource Powersource

Labels
blocked issues that currently can't progress due to waiting on some other issue/process priority: high
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Try 'eth_requestAccounts' as a workaround for enabling privacy mode SuperuserLabs/thankful
2 participants
@ErikBjare @Powersource