Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A lot of errors with AsyncClient (Performance issue) #75

Open
bohdan-krupa opened this issue Aug 26, 2024 · 4 comments
Open

A lot of errors with AsyncClient (Performance issue) #75

bohdan-krupa opened this issue Aug 26, 2024 · 4 comments

Comments

@bohdan-krupa
Copy link

The package is not high-performance as it doesn't support async mode. With AsyncClient a lot of errors occur.

Here is an example of one of them:
AttributeError: 'AsyncClient' object has no attribute 'build_and_send_request'. Did you mean: 'build_and_send_request_async'?

@skrtdev
Copy link
Contributor

skrtdev commented Oct 7, 2024

i have a patch for it, maybe i'll do a pull request

@GitBolt
Copy link
Collaborator

GitBolt commented Oct 7, 2024

i have a patch for it, maybe i'll do a pull request

would be appreciated! @skrtdev

@skrtdev
Copy link
Contributor

skrtdev commented Oct 7, 2024

@GitBolt actually the code needs some refactoring, especially in the async version (which lets me think no one actually tested it before pushing it, since it does not even work in most cases). I did that too but i developed a patch without touching the original source code. I will apply it to the original source code and make a pull request. In the meanwhile, please merge #79

@GitBolt
Copy link
Collaborator

GitBolt commented Oct 7, 2024

@skrtdev thank you, merged. yes async seems to have more issues. appreciate you working on fixing them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@bohdan-krupa @skrtdev @GitBolt and others