-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A lot of errors with AsyncClient (Performance issue) #75
Comments
i have a patch for it, maybe i'll do a pull request |
would be appreciated! @skrtdev |
@GitBolt actually the code needs some refactoring, especially in the async version (which lets me think no one actually tested it before pushing it, since it does not even work in most cases). I did that too but i developed a patch without touching the original source code. I will apply it to the original source code and make a pull request. In the meanwhile, please merge #79 |
@skrtdev thank you, merged. yes async seems to have more issues. appreciate you working on fixing them! |
The package is not high-performance as it doesn't support async mode. With AsyncClient a lot of errors occur.
Here is an example of one of them:
AttributeError: 'AsyncClient' object has no attribute 'build_and_send_request'. Did you mean: 'build_and_send_request_async'?
The text was updated successfully, but these errors were encountered: