Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triggering Compile action without storage space and without having the build directory in place hangs forever #298

Open
filippsen opened this issue Dec 17, 2018 · 0 comments
Labels
bug Something isn't working

Comments

@filippsen
Copy link
Contributor

filippsen commented Dec 17, 2018

Environment/Browser

Version 1.3.0

Description

When compiling under the full storage conditions (no space left) and without having the build directory in place at all, the compiler hangs forever (spinning icon). This only happens when there is no room for even creating the build file (directory).
Dozens of alert messages will also pop up (possibly a recursive error ? infinite alerts? ):

Could not save dappfile.

Steps to reproduce

  1. Get to a point where the local storage is full *
  2. Make sure the build directory is not present (If needed, delete it and double check there is no more room for storing anything afterwards)
  3. Click the Compile action

Expected result

Error message or alert without any console errors.

Actual result

It appears that setItem (in saveFile) fails to execute due to lack of storage space, resulting in unhandled DOMException.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants