Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Tux from wanting to take baths in lava #3109

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tobbi
Copy link
Member

@tobbi tobbi commented Nov 22, 2024

I propose the following code change to prevent Tux from swimming in lava baths unless he has the invincibility star. That means that once Tux enters lava, he'll fall right through. During invincibility, Tux will swim as usual.

@Frostwithasideofsalt
Copy link
Member

not too big of a fan of this change. i prefer having tux being able to swim in it always, so he has a chance to get out if he falls in.

@Vankata453
Copy link
Member

IMO letting Tux swim in the lava could allow for some interesting level gimmicks and is also more logical:

  • This is inconsistent with how (at least I have perceived) the swimming mechanic logically allows Tux to swim in liquids.
  • If Tux shouldn't swim in the lava, the other way it could be done it is to kill him instantly whenever he touches it, but that is then inconsistent with how powerups work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants