Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display branch name and commit hash in window title #3001

Closed
wants to merge 5 commits into from

Conversation

MatusGuy
Copy link
Member

@MatusGuy MatusGuy commented Jul 6, 2024

This pull request also removes complexity in the CMake code for git querying and version.h generation.

@MatusGuy MatusGuy requested review from tobbi and Vankata453 July 6, 2024 13:47
@MatusGuy MatusGuy added priority:low type:patch status:needs-review Work needs to be reviewed by other people labels Jul 6, 2024
Copy link
Member

@tobbi tobbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make it display at least the base version of the game when git wasn't found.

@swagtoy
Copy link
Contributor

swagtoy commented Nov 3, 2024

After a very brief discussion, I will cherrypick this PR in #3093

@swagtoy swagtoy mentioned this pull request Nov 3, 2024
8 tasks
@MatusGuy MatusGuy closed this Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:low status:needs-review Work needs to be reviewed by other people type:patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants