Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display music metadata in the level editor #2674

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Display music metadata in the level editor #2674

wants to merge 6 commits into from

Commits on Aug 2, 2024

  1. Display author, title, license in the level editor music browser (Sup… 

    …erTux#2617)

Whenever any of author, title and license fields are defined for music
files, help text showing this music metadata is displayed when hovering
over ".music" files in the level editor music object file browser.

This commit adds both the software implementation and author, title,
and license values added to SuperTux music files in data/music.
The game credits and data/AUTHORS are updated in some cases where there
is new authorship data.

Fixes SuperTux#2617.
    @jamescdericco
    jamescdericco committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    c579652 View commit details
    Browse the repository at this point in the history

  2. editor_converters_menu.cpp: Fix indentation code style 

    Co-authored-by: Vankata453 <[email protected]>
    @jamescdericco @Vankata453
    jamescdericco and Vankata453 authored Aug 2, 2024
    Configuration menu
    Copy the full SHA
    1065b33 View commit details
    Browse the repository at this point in the history

  3. Move item_processor_music_help function into object_settings.cpp 

    Resolves code review issue pointing out that this standalone function
is out of place among the classes of the src/gui folder.
item_processor is now specified using an anonymous function
in the method ObjectSettings::add_music().
    @jamescdericco
    jamescdericco committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    6cea5c1 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2024

  1. Add new line to salcon.music 

    [ci skip]
    @tobbi
    tobbi authored Aug 3, 2024
    Configuration menu
    Copy the full SHA
    c4de5c7 View commit details
    Browse the repository at this point in the history

  2. Add new line to forest2.music 

    [ci skip]
    @tobbi
    tobbi authored Aug 3, 2024
    Configuration menu
    Copy the full SHA
    bc615f9 View commit details
    Browse the repository at this point in the history

  3. Add new line to forest3.music 

    [ci skip]
    @tobbi
    tobbi authored Aug 3, 2024
    Configuration menu
    Copy the full SHA
    8bd4900 View commit details
    Browse the repository at this point in the history