Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming classes #7

Open
larshp opened this issue Dec 4, 2016 · 3 comments
Open

Renaming classes #7

larshp opened this issue Dec 4, 2016 · 3 comments

Comments

@larshp
Copy link
Collaborator

larshp commented Dec 4, 2016 •
edited
Loading

Hi @Sumu-Ning,
I would like to rename the classes so everything is prefixed with "ZCL_AES_", my suggestion:

rename ZCL_BYTE_PADDING_UTILITY to ZCL_AES_PADDING
rename ZCL_PADDING_UTILITY_NONE to ZCL_AES_PADDING_NONE
rename ZCL_PADDING_UTILITY_PKCS_5 to ZCL_AES_PADDING_PKCS_5
rename ZCL_PADDING_UTILITY_PKCS_7 to ZCL_AES_PADDING_PKCS_7

rename ZCL_RIJNDAEL_UTILITY to ZCL_AES_RIJNDAEL
@larshp larshp changed the title renaming classes Renaming classes Dec 4, 2016
@larshp
Copy link
Collaborator Author

larshp commented Dec 13, 2016

@Sumu-Ning any opinion on this?

@Sumu-Ning
Copy link
Owner

I am fine with them, except for the last one, which is more fundamental than aes.

If you have time , please make the change. I don't have abap environment any more :p

@larshp
Copy link
Collaborator Author

larshp commented Jan 5, 2017

Will do, just haven't had the time/focus to do it yet

Sumu-Ning added a commit that referenced this issue Mar 15, 2021
@Sumu-Ning
Update README.md - Suggest using PKCS #7 Padding
861be83
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@larshp @Sumu-Ning