Modify teleport to move vehicle #2111
Open
+59
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tornac1234
added
Area: vehicles
Jannify
requested changes
May 16, 2024
| } | ||
| catch (Exception e) | ||
| { | ||
| // Freeze the player while he's loading its new position |
There was a problem hiding this comment.
Suggested change
| // Freeze the player while he's loading its new position |
NitroxClient/Communication/Packets/Processors/PlayerTeleportedProcessor.cs
Show resolved
Hide resolved
|
|
||
| Vehicle currentVehicle = Player.main.currentMountedVehicle; | ||
| // Check to make sure the player is in a vehicle | ||
| if (currentVehicle != null) |
There was a problem hiding this comment.
It's heavily advised to not check unity components and gameobjects against null. Instead just handle the object as a bool.
Suggested change
| if (currentVehicle != null) | |
| if (currentVehicle) |
See: https://discussions.unity.com/t/how-can-i-check-if-an-object-is-null/23224/4
| public static bool Prefix(Vector3 position, bool gotoImmediate = false) | ||
| { | ||
| Vehicle currentMountedVehicle = Player.main.currentMountedVehicle; | ||
| if (currentMountedVehicle == null) |
There was a problem hiding this comment.
Same here with checking against null
Suggested change
| if (currentMountedVehicle == null) | |
| if (!currentMountedVehicle) |
|
|
||
| public sealed partial class GoTo_Patch : NitroxPatch, IDynamicPatch | ||
| { | ||
| public static readonly MethodInfo TARGET_METHOD = Reflect.Method((GotoConsoleCommand gotoConsoleCommand) => gotoConsoleCommand.GotoPosition(default, default)); |
There was a problem hiding this comment.
Minor, just bc other patched have it this way:
Suggested change
| public static readonly MethodInfo TARGET_METHOD = Reflect.Method((GotoConsoleCommand gotoConsoleCommand) => gotoConsoleCommand.GotoPosition(default, default)); | |
| public static readonly MethodInfo TARGET_METHOD = Reflect.Method((GotoConsoleCommand t) => t.GotoPosition(default, default)); |
| @@ -0,0 +1,22 @@ | |||
| using System.Reflection; | |||
| using HarmonyLib; | |||
There was a problem hiding this comment.
Suggested change
| using HarmonyLib; |
|
|
||
| namespace NitroxPatcher.Patches.Dynamic; | ||
|
|
||
| public sealed partial class GoTo_Patch : NitroxPatch, IDynamicPatch |
There was a problem hiding this comment.
Patches are named like: <PatchedClass>_<PatchedMethod>_Patch.cs. Could you rename the file and class in this fashion?
Jannify
reviewed
Sep 24, 2024
| { | ||
| public static readonly MethodInfo TARGET_METHOD = Reflect.Method((GotoConsoleCommand t) => t.GotoPosition(default, default)); | ||
|
|
||
| public static bool Prefix(Vector3 position, bool gotoImmediate = false) |
There was a problem hiding this comment.
You don't need to include the parameters if you don't need them.
Suggested change
| public static bool Prefix(Vector3 position, bool gotoImmediate = false) | |
| public static bool Prefix(Vector3 position) |
Jannify
approved these changes
Sep 24, 2024
tornac1234
requested changes
Nov 18, 2024
…nd to teleport that Rigidbody if present
MistaOmega
force-pushed
the
Modify-Teleport-To-Move-Vehicle
branch
from
79b87b0
to
495287f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to modify the vehicle teleport behaviour.
Correctly updates player pos with player in seamoth / prawn