Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtitles seeking support #465

Open
umlx5h opened this issue May 17, 2024 · 2 comments
Open

Subtitles seeking support #465

umlx5h opened this issue May 17, 2024 · 2 comments
Labels
enhancement New feature or request v4

Comments

@umlx5h
Copy link
Contributor

umlx5h commented May 17, 2024

Hello.
Sorry for posting two feature requests.

I would like to add the ability to seek with subtitles like mpv, but it looks like this needs to be addressed by the library itself.

For example in mpv, It is convenient to seek between subtitles with ASD with the following settings.

a no-osd sub-seek -1
d no-osd sub-seek 1
s no-osd sub-seek 0

https://mpv.io/manual/master/#command-interface-sub-seek

It would be nice if both built-in and external subtitles could be supported.

@SuRGeoNix SuRGeoNix added the enhancement New feature or request label May 17, 2024
@SuRGeoNix
Copy link
Owner

Hi @umlx5h, that will not be easy to add in the current implementation. As it will need to seek based on subtitles stream (it would be easier if all packets were cached, but now it does not) and the seek again accurately for the video keyframe before that timestamp (which means demux and decode until the subtitles timestamp). I will have this in mind for the next major update.

@umlx5h
Copy link
Contributor Author

umlx5h commented May 18, 2024

thanks for your reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v4
Projects
None yet
Development

No branches or pull requests

2 participants