Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White color on pull request comment box #1258

Closed
ItsDrike opened this issue Oct 30, 2020 · 9 comments
Closed

White color on pull request comment box #1258

ItsDrike opened this issue Oct 30, 2020 · 9 comments
Labels
bug 🐛 Something isn't working

Comments

@ItsDrike
Copy link

  • Browser: Firefox 82.0.2 (64-bit)

  • Operating System: Arch Linux (kernel: linux 5.9.2.arch1-1)

  • Link to page with the issue: Rework the database system into a more modular model Codin-Nerds/Neutron-Bot#11

  • Screenshot:
    image

  • Description: I'm not sure why but the comment box on any pull request on one of my repositories is white. I've checked other repositories and I couldn't replicate this behavior on other repositories.

@ItsDrike ItsDrike added the bug 🐛 Something isn't working label Oct 30, 2020
@ItsDrike
Copy link
Author

ItsDrike commented Oct 30, 2020

Actually, it seems like this occurs in all of the comments made by me, both on PRs and issues. Even this one
image

@The-EDev
Copy link

the issue seems to be that timeline-comment.current-user .timeline-comment-header has no background-color property, so it uses the default one (#9daccc)

@The-EDev
Copy link

I added these to the stylesheet to fix the issue:
(I only added background-color for this one)

  .timeline-comment.current-user .timeline-comment-header {
    border-bottom-color: var(--color-auto-blue-2, #246);
      background-color: #1b2937;
  }
  .timeline-comment--caret.current-user::after {
    border-right-color: #1b2937;
  }

@silverwind
Copy link
Member

Hmm, not seeing this, my comments are blue to myself as usual.

@ItsDrike
Copy link
Author

ItsDrike commented Oct 31, 2020

Hmm, not seeing this, my comments are blue to myself as usual.

@silverwind

Interesting, I even deleted the style and reinstalled it but it didn't help, maybe you're on an outdated version?

@silverwind
Copy link
Member

No, latest master of course. Are you opted in to any GitHub experiments maybe?

@ItsDrike
Copy link
Author

Not that I'm aware of, when i click on Feature preview on my profile there's nothing
image

Not sure if this is what you meant though.

@silverwind
Copy link
Member

Check if v4.2.41 just released solves it.

@The-EDev
Copy link

@silverwind seems to be fixed for me (after updating to 4.2.41)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants