Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Danish Characters are not supported #41

Open
KnutssonDevelopment opened this issue Feb 17, 2023 · 3 comments
Open

Danish Characters are not supported #41

KnutssonDevelopment opened this issue Feb 17, 2023 · 3 comments

Comments

@KnutssonDevelopment
Copy link

If I put any danish characters in the title or in text somewhere is does not work. I will show either "?" or some weird characters.

Characters testes are: "æøå"

@DownLoude
Copy link

DownLoude commented Mar 31, 2023

That's just a C++ thing. You have to input stings and specify UTF-8.

"æøå"

will not work, but

u8"æøå"

will.

@TheCherno
Copy link
Collaborator

@DownLoude no you don't, std::string supports UTF-8 in C++, so you can just write std::string str = "æøå"; In the case of ImGui, it also supports UTF-8 with just a normal const char* so it will attempt to render the correct glyphs.

@KnutssonDevelopment the reason why those characters are show up as ? is because the glyphs aren't loaded from the font, or the font doesn't have those glyphs and thus they also weren't loaded.

I haven't thought about how to handle this yet in Walnut; as in, how should we specify which glyphs/character sets/languages we want to load from the font, but I'm open to suggestions.

@Zydnar
Copy link

Zydnar commented Dec 30, 2023

@TheCherno

or the font doesn't have those glyphs

It does - I installed the Roboto font from Walnut as system font, also in font preview it does seem to have these glyps. Could they be dynamically loaded depending on characters in provided string? If not I would leave it as a setting up to the developer. Symfony is PHP framework but they have nice ecosystem where by default you generate very minimal app and everything else is up to the developer - modules you want to be included. I think it's a nice solution. In fact Walnut .lua scripts remind mea bit of https://github.com/symfony/recipes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants