New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SMC ABC doesn't stop when max_rounds == 1 #17

Open

BryanRumsey opened this issue Apr 6, 2023 · 0 comments

Labels

bug

BryanRumsey commented Apr 6, 2023

Proposed fixes

RelativeEpsilonSelector constructor should raise an error if max_rounds == 0 and the doc string should indicate the required value.
relative_epsilon_selector.py line 55: should return self.max_rounds == 1 for the has_more return value.
smc_abc.py line 182: round should have an initial value of 2.
relative_epsilon_selector.py line 81: should return self.max_rounds and round >= self.max_rounds for the terminate return value.

The text was updated successfully, but these errors were encountered:

BryanRumsey added the bug label

BryanRumsey mentioned this issue

Fixed the epsilon selectors so they correctly handle the rounds. #21

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment