Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report] Resetting the properties by changing the ShaderPath #180

Open
nilBrain opened this issue Sep 22, 2023 · 0 comments
Open

[Bug Report] Resetting the properties by changing the ShaderPath #180

nilBrain opened this issue Sep 22, 2023 · 0 comments
Assignees
@StjerneIdioten
Labels
bug Something isn't working

Comments

@nilBrain
Copy link

When changing the ShaderPath in I3D Shader Settings | Shader Source, the properties are not kept if it is the same Shader and Variations.
@nilBrain nilBrain added bug Something isn't working Needs Auditing Issues that should be audited by a dev before being considered labels Sep 22, 2023
NMC-TBone added a commit to NMC-TBone/I3D-Blender-Addon that referenced this issue Sep 23, 2023
@NMC-TBone
fix(shader): Prevent resetting parameters in shader settings
8365653 
Introduce an early return check for the shader's variation. If the selected variation is the same as the previously active one, the function exits early, preventing any unnecessary resetting of shader parameters.

Fix StjerneIdioten#180
@StjerneIdioten StjerneIdioten removed the Needs Auditing Issues that should be audited by a dev before being considered label Sep 25, 2023
StjerneIdioten pushed a commit that referenced this issue Nov 29, 2023
@NMC-TBone
Changes to how you add shaders in the UI (#182)
c73843b 
* fix(shader): Prevent resetting parameters in shader settings

Introduce an early return check for the shader's variation. If the selected variation is the same as the previously active one, the function exits early, preventing any unnecessary resetting of shader parameters.

Fix #180

* feat(material): New way of adding shaders

- The shaders will now be automatically loaded in a EnumProperty through the data path set in addon preferences
- This includes a operator that will migrate the old "source" property over to the new "shader" enum property (and preserve all the other shader related data)
- Made it possible to add "material_name" to the load_shader and load_shader_variation operators so it can be called through API without needing to have a active object with a active material to run the operators

* Added support to export new shader setup
StjerneIdioten pushed a commit that referenced this issue Feb 16, 2024
@NMC-TBone @StjerneIdioten
Changes to how you add shaders in the UI (#182)
756958f 
* fix(shader): Prevent resetting parameters in shader settings

Introduce an early return check for the shader's variation. If the selected variation is the same as the previously active one, the function exits early, preventing any unnecessary resetting of shader parameters.

Fix #180

* feat(material): New way of adding shaders

- The shaders will now be automatically loaded in a EnumProperty through the data path set in addon preferences
- This includes a operator that will migrate the old "source" property over to the new "shader" enum property (and preserve all the other shader related data)
- Made it possible to add "material_name" to the load_shader and load_shader_variation operators so it can be called through API without needing to have a active object with a active material to run the operators

* Added support to export new shader setup
@StjerneIdioten StjerneIdioten self-assigned this Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StjerneIdioten StjerneIdioten

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@StjerneIdioten @nilBrain