You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Very small issue here, but I recently discovered that there is a double instantiation of the Os::Log class.
The first instantiation is found in the Main.cpp file for Arduino deployments on line 52, right after the #ifdef statement setting up the Serial logger.
Os::Log logger;
The second instantiation is found in the Topology.cpp file on line 38 after the enum of context ID's. This one
Os::Log osLogger;
This one probably goes all the way back to the Ref deployment.
While this double instantiation doesn't affect anything negatively, you can safely remove either of these instantiations without any effect on the functionality of the particular instance of the Fw::Logger that's currently registered. Happy to discuss this more, but I've run out of time for now and just wanted to get this written down initially.
The text was updated successfully, but these errors were encountered:
Very small issue here, but I recently discovered that there is a double instantiation of the
Os::Log
class.The first instantiation is found in the
Main.cpp
file for Arduino deployments on line 52, right after the#ifdef
statement setting up the Serial logger.The second instantiation is found in the
Topology.cpp
file on line 38 after the enum of context ID's. This oneThis one probably goes all the way back to the Ref deployment.
While this double instantiation doesn't affect anything negatively, you can safely remove either of these instantiations without any effect on the functionality of the particular instance of the
Fw::Logger
that's currently registered. Happy to discuss this more, but I've run out of time for now and just wanted to get this written down initially.The text was updated successfully, but these errors were encountered: