Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double instantiation of Os::Log logger #15

Open
legounicycler opened this issue Apr 22, 2022 · 0 comments
Open

Double instantiation of Os::Log logger #15

legounicycler opened this issue Apr 22, 2022 · 0 comments

Comments

@legounicycler
Copy link

Very small issue here, but I recently discovered that there is a double instantiation of the Os::Log class.

The first instantiation is found in the Main.cpp file for Arduino deployments on line 52, right after the #ifdef statement setting up the Serial logger.

Os::Log logger;

The second instantiation is found in the Topology.cpp file on line 38 after the enum of context ID's. This one

Os::Log osLogger;

This one probably goes all the way back to the Ref deployment.

While this double instantiation doesn't affect anything negatively, you can safely remove either of these instantiations without any effect on the functionality of the particular instance of the Fw::Logger that's currently registered. Happy to discuss this more, but I've run out of time for now and just wanted to get this written down initially.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant