Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Use of Baremetal Scheduler Flag in Deployment Level CMakeLists.txt for Fprime 2.X #12

Open
EbenezerA99 opened this issue Feb 23, 2022 · 2 comments

Comments

@EbenezerA99
Copy link

In the deployment level CMakeLists.txt, the following line is used to specify whether the Baremetal Scheduler should be used for a specific deployment:

set(BAREMETAL_SCHEDULER CACHE BOOL ON "Uses the baremetal scheduler")

However, with Fprime 2.0, the flag that specifies the use of the baremetal scheduler is actually FPRIME_USE_BAREMETAL_SCHEDULER, necessitating that the new line in the deployment Cmakelists.txt be something like:

set(FPRIME_USE_BAREMETAL_SCHEDULER ON).

Within the repository, the cookiecutter should check to see if the user has specified a baremetal deployment and then set the variable as necessary here, along these lines:

{% if cookiecutter.deployment_baremetal_scheduler == "yes" -%}
set(FPRIME_USE_BAREMETAL_SCHEDULER ON)
{%- endif %}

@SterlingPeet
Copy link
Owner

Do we know for sure that this is variable name was changed? In other words, do you think I can blindly change this variable name with no adverse consequences or do you think we need to keep the old variable too?

@EbenezerA99
Copy link
Author

I did a search of the entire repo and don't see them using the BAREMETAL_SCHEDULER variable at all anymore, they only use this: FPRIME_USE_BAREMETAL_SCHEDULER.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants