Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

double_stars.ssc : RA and Dec are shift. #3835

Closed
3domennotry opened this issue Aug 1, 2024 · 14 comments
Closed

double_stars.ssc : RA and Dec are shift. #3835

3domennotry opened this issue Aug 1, 2024 · 14 comments
Assignees
Labels
bug Something likely wrong in the code state: confirmed A developer can reproduce the issue
Milestone

Comments

@3domennotry
Copy link

3domennotry commented Aug 1, 2024

Expected Behaviour

Actual Behaviour

RA and Dec are shift.

For example: θ Orionis is not shown(out of screen).

Steps to reproduce

  1. Start Script double_stars.ssc.

System

  • Stellarium version: stellarium-24.2-qt5-win32.exe

    • stellarium-24.2-98544be-patch-qt5-win32.exe
    • stellarium-24.2-623f996-patch-qt5-win32.exe
  • Operating system: Win7 32bit

In this script, current RA and DEC were used.
(I think that maybe it is middle position.)

line28 to 47
e.g. ["03h46m45.16s", "+24d35m44.5s",

line74
core.moveToRaDec(doublestar[j][0], doublestar[j][1]);

current RA and DEC shifts day by day.

This is my personal opinion.

current RA and DEC are not use.
J2000.0 RA and DEC are use.

Return to the date and time of those coordinates.
(Not sure if this is possible with scripts.)

Calculate middle position.

This is sample.

θ Ori:
center of four θ1 Ori might be better than brightest θ1 Ori C.
As same as Mizar, etc...

ε Lyr :
I created a calculation method for the "double-double" mode.
However,
HIP 91919 A and HIP 91919 B have the same value(RA, Dec).
HIP 91926 C and HIP 91926 D have the same value(RA, Dec).

(Sorry, I can not speak English very well.)

thank you.

@3domennotry
Copy link
Author

sample is.
20240801_1-1.txt

@alex-w alex-w self-assigned this Aug 1, 2024
@alex-w alex-w added this to the 24.3 milestone Aug 1, 2024
@alex-w alex-w added the bug Something likely wrong in the code label Aug 1, 2024
@gzotti
Copy link
Member

gzotti commented Aug 1, 2024

It seems some coords (at least RA for theta Ori) are wrong. And using J2000 coordinates may be not enough when magnification is high, given shifts by proper motion, nutation and aberration. Maybe it is better to actually search for those stars by name. Or switch off nutation and aberration. And yes, use moveToRaDecJ2000() when dealing with J2000 coordinates.

@alex-w alex-w added the state: confirmed A developer can reproduce the issue label Aug 1, 2024
Copy link

github-actions bot commented Aug 1, 2024

Hello @3domennotry!

OK, developers can reproduce the issue. Thanks for the report!

@alex-w
Copy link
Member

alex-w commented Aug 20, 2024

Proposed solution depend on issue #3836

@alex-w alex-w added the state: blocked Being blocked by another PR or issue label Aug 20, 2024
Copy link

Hello @3domennotry!

This issue being blocked by another PR or issue. Thanks for the report!

@3domennotry
Copy link
Author

I fixed this bug.
I don't think this bug is related to issue #3836.
Please, try and use this file.
double_stars.ssc.txt

@alex-w
Copy link
Member

alex-w commented Aug 20, 2024

Not a bug, but solution will not work as expected due issue #3836

@alex-w alex-w closed this as completed in e689ff5 Sep 19, 2024
@alex-w alex-w added state: published The fix has been published for testing in weekly binary package and removed state: blocked Being blocked by another PR or issue labels Sep 20, 2024
Copy link

Hello @3domennotry!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Sep 22, 2024
Copy link

Hello @3domennotry!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

@3domennotry
Copy link
Author

I have confirmed in stellarium-24.3-qt5-win32.exe.

Roughly fixed.
Unfortunately, problem remains.

These RA and Dec, what is designated?

Maybe, many star pairs are designated in the middle position.

But,
Case of θ Ori: θ2 Ori is out of Screen.
Case of ζ Crv: ζ Crv is Center of screen.

20240801_2024_0923_1
20240801_2024_0923_2
20240801_2024_0923_3
20240801_2024_0923_4

Why don't you adopt the calculation method I created?

thank you.

@alex-w
Copy link
Member

alex-w commented Sep 23, 2024

Why don't you adopt the calculation method I created?

They will not work correctly due specifics of Search Engine

@3domennotry
Copy link
Author

This script(I made) is working fine in my environment(win7).
Does it mean that it does not work correctly in other environments?

thank you.

@alex-w
Copy link
Member

alex-w commented Sep 23, 2024

This script(I made) is working fine in my environment(win7). Does it mean that it does not work correctly in other environments?

The stars HIP 20648 A, HIP 26221 A, HIP 26235 E, HIP 60157 A, HIP 91919 A, HIP 91919 B, HIP 91926 C, HIP 91926 D, HIP 100027 A will not searched in the scripts nor Search Engine.

@3domennotry
Copy link
Author

"search engine specifications" and "issue #3836"
Soory, I finally figured out what it means.

My script, perhaps ignoring the alphabetical part of the HIP.
This isn't sufficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something likely wrong in the code state: confirmed A developer can reproduce the issue
Development

No branches or pull requests

3 participants