Steghide Makefile fails with critical error on Ubuntu 18.04

[M-Davies]

Copied from StegHigh/steghide#4. Issue may no longer be valid

What I did

• Ran ./configure on an Ubuntu 18.04 machine (within VirtualBox) with libmhash, libmcrypt, zlib and libjpeg installed
• Ran make

What I expected to happen

• make completed successfully

What actually happened

• Makefile failed with the below error. Running as root did not change the result.

stego@stego-VirtualBox:~/Documents/steghide$ make 
make  all-recursive
make[1]: Entering directory '/home/stego/Documents/steghide'
Making all in m4
make[2]: Entering directory '/home/stego/Documents/steghide/m4'
make[2]: Nothing to be done for 'all'.
make[2]: Leaving directory '/home/stego/Documents/steghide/m4'
Making all in intl
make[2]: Entering directory '/home/stego/Documents/steghide/intl'
make[2]: Nothing to be done for 'all'.
make[2]: Leaving directory '/home/stego/Documents/steghide/intl'
Making all in po
make[2]: Entering directory '/home/stego/Documents/steghide/po'
make[2]: Nothing to be done for 'all'.
make[2]: Leaving directory '/home/stego/Documents/steghide/po'
Making all in doc
make[2]: Entering directory '/home/stego/Documents/steghide/doc'
make[2]: Nothing to be done for 'all'.
make[2]: Leaving directory '/home/stego/Documents/steghide/doc'
Making all in src
make[2]: Entering directory '/home/stego/Documents/steghide/src'
if g++ -DHAVE_CONFIG_H -I. -I. -I..  -DLOCALEDIR=\"/usr/local/share/locale\"   -O2 -Wall -MT Arguments.o -MD -MP -MF ".deps/Arguments.Tpo" \
  -c -o Arguments.o `test -f 'Arguments.cc' || echo './'`Arguments.cc; \
then mv ".deps/Arguments.Tpo" ".deps/Arguments.Po"; \
else rm -f ".deps/Arguments.Tpo"; exit 1; \
fi
In file included from common.h:101:0,
                 from MCryptPP.h:21,
                 from Arguments.cc:25:
Arguments.h:103:22: error: ‘constexpr’ needed for in-class initialization of static data member ‘const float Arguments::Default_Goal’ of non-integral type [-fpermissive]
  static const float  Default_Goal = 100.0 ;
                      ^~~~~~~~~~~~
Makefile:395: recipe for target 'Arguments.o' failed
make[2]: *** [Arguments.o] Error 1
make[2]: Leaving directory '/home/stego/Documents/steghide/src'
Makefile:259: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/home/stego/Documents/steghide'
Makefile:190: recipe for target 'all' failed
make: *** [all] Error 2

[StefanoDeVuono]

@M-Davies Thanks for bringing over the issue. Seriously. It's great to see people receptive to reviving development on steghide.

Can you try on Ubuntu 18.04 and see if you can replicate this issue?