diff --git a/CHANGELOG.md b/CHANGELOG.md index e202d22..6fd2561 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,15 @@ # History of changes (since 5/2022) +## Release 1.2.4 + +### Bugfixes +* i18n usage for Measurement threshold info in Measurement-View + +## Release 1.2.3 + +### New Features +* SABI-146: Support to add freshwater tanks as well + ## Release 1.2.2 ### Technical Maintenance diff --git a/DEVELOPERS_MANUAL.md b/DEVELOPERS_MANUAL.md index e3a0463..476d5f4 100644 --- a/DEVELOPERS_MANUAL.md +++ b/DEVELOPERS_MANUAL.md @@ -4,14 +4,6 @@ The following helps new developers to setup the required local build environment ## Technology Stack -[![CodeQL](https://github.com/StefanSchubert/sabi/actions/workflows/codeql-analysis.yml/badge.svg)](https://github.com/StefanSchubert/sabi/actions/workflows/codeql-analysis.yml) -[![Java CI with Maven](https://github.com/StefanSchubert/sabi/actions/workflows/maven.yml/badge.svg)](https://github.com/StefanSchubert/sabi/actions/workflows/maven.yml) - -## Architectural Notes - -Before starting to contribute on this project, make sure that you have read the architectural notes in the [wiki](https://github.com/StefanSchubert/sabi/wiki) which -are based upon arc42 templates. - ### Common * Java 21 @@ -43,6 +35,18 @@ The two main reasons for me are: ---- +## Architectural Notes + +Before starting to contribute on this project, make sure that you have read the architectural notes in the [wiki](https://github.com/StefanSchubert/sabi/wiki) which +are based upon arc42 templates. + +### Current Code-Quality State + +[![CodeQL](https://github.com/StefanSchubert/sabi/actions/workflows/codeql-analysis.yml/badge.svg)](https://github.com/StefanSchubert/sabi/actions/workflows/codeql-analysis.yml) +[![Java CI with Maven](https://github.com/StefanSchubert/sabi/actions/workflows/maven.yml/badge.svg)](https://github.com/StefanSchubert/sabi/actions/workflows/maven.yml) + +---- + ## Setting up the development environment With a look at [Building-Block View](https://github.com/StefanSchubert/sabi/wiki/05.-Building-Block-View) from the arc42 documentation you see that sabi is not just a single app but consists of using several modules that are configured to work together. Your environment might look different, depending on which module you intent to work on, but the good news is that we already rely on docker here, which makes the setup for you so much easier. diff --git a/sabi-database/src/main/resources/db/migration/version1_3_0/V1_3_0_1__addedWaterType.sql b/sabi-database/src/main/resources/db/migration/version1_3_0/V1_3_0_1__addedWaterType.sql new file mode 100644 index 0000000..a10673f --- /dev/null +++ b/sabi-database/src/main/resources/db/migration/version1_3_0/V1_3_0_1__addedWaterType.sql @@ -0,0 +1 @@ +ALTER TABLE `aquarium` ADD COLUMN `water_type` VARCHAR(20) DEFAULT 'SEA_WATER'; diff --git a/sabi-webclient/pom.xml b/sabi-webclient/pom.xml index 36367ba..1ba35b5 100644 --- a/sabi-webclient/pom.xml +++ b/sabi-webclient/pom.xml @@ -1,6 +1,6 @@ @@ -10,7 +10,7 @@ de.bluewhale sabi-webclient - 1.2.3 + 1.2.4 jar sabi-webclient A JSF based webclient for sabi. @@ -57,11 +57,11 @@ 21 2.20.0 4.0.1 - 1.12.1 + 1.12.2 5.1.4 1.2.5 1.6.4 - 9.0.7 + 9.0.9 1.18.30 2.16.2 diff --git a/sabi-webclient/src/main/java/de/bluewhale/sabi/webclient/controller/MeasurementListView.java b/sabi-webclient/src/main/java/de/bluewhale/sabi/webclient/controller/MeasurementListView.java index 765df3c..98abc67 100644 --- a/sabi-webclient/src/main/java/de/bluewhale/sabi/webclient/controller/MeasurementListView.java +++ b/sabi-webclient/src/main/java/de/bluewhale/sabi/webclient/controller/MeasurementListView.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2021 by Stefan Schubert under the MIT License (MIT). + * Copyright (c) 2024 by Stefan Schubert under the MIT License (MIT). * See project LICENSE file for the detailed terms and conditions. */ @@ -26,6 +26,7 @@ import java.io.Serializable; import java.util.Collections; import java.util.List; +import java.util.Locale; /** * Controller for the Measurement View as shown in measureView.xhtml @@ -159,8 +160,9 @@ public String getGetThresholdInfoFor(Integer unitId) { if (unitId != null && unitId != 0) { try { ParameterTo parameterTo = measurementService.getParameterFor(unitId, userSession.getSabiBackendToken()); - if (parameterTo != null) { - result = String.format("min = %.03f / max = %.03f", parameterTo.getMinThreshold(), parameterTo.getMaxThreshold()); + Locale usersLocale = userSession.getLocale(); + if (parameterTo != null && usersLocale != null) { + result = String.format(usersLocale, "min = %.03f / max = %.03f", parameterTo.getMinThreshold(), parameterTo.getMaxThreshold()); } } catch (Exception e) { log.warn("Could not resolve parameter info for unit {}", unitId);