Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't depend on the androidartifacts plugin but react on it #38

Closed
StefMa opened this issue Dec 21, 2018 · 0 comments · Fixed by #39
Closed

Don't depend on the androidartifacts plugin but react on it #38

StefMa opened this issue Dec 21, 2018 · 0 comments · Fixed by #39

Comments

@StefMa
Copy link
Owner

StefMa commented Dec 21, 2018

Goes hand in hand with #32 #31 and #34 ... somehow

Currently we apply the guru.stefma.artifacts plugin when this plugin got applied:

project.pluginManager.apply("guru.stefma.artifacts")

The better approach would be to "react" on the plugin - if its already applied.
So we have a way better separation:

  • When the guru.stefma.artifacts plugin is applied (or better some "base plugin" so we can make sure that it is really applied)
  • Then we can do our work

Otherwise we do nothing...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant