New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Eureka documentation on how to use client certificate #325

Open

bart-vmware opened this issue Jun 11, 2024 · 0 comments

Member

bart-vmware commented Jun 11, 2024 •

edited

Loading

Update the documentation at https://github.com/SteeltoeOSS/Documentation/blob/v4/api/v4/discovery/netflix-eureka.md#configuring-mutual-tls.

After merge of SteeltoeOSS/Steeltoe#1306, the new way is to just add entries in configuration (appsettings, config server, etc):

"ClientCertificates:Eureka:CertificateFilePath"
"ClientCertificates:Eureka:PrivateKeyFilePath" (optional, for using PEM)

Follow-up from SteeltoeOSS/Steeltoe#1306 (comment)_

bart-vmware changed the title AddCertificate only puts the files into IConfiguration, without setting up change tracking. I think that AddEurekaDiscoveryClient internally should call services.ConfigureCertificateOptions() (assuming that doesn't log errors or throw when the certificate path is not in configuration). And expect users to add the certificate paths to appsettings.json instead of calling this method, so that the paths can change at runtime. Update Eureka documentation on how to use client certificate

bart-vmware mentioned this issue

Use named options for client certificates SteeltoeOSS/Steeltoe#1306

Merged

5 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment