-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parameter for not restricting access to the named tempfile #61
Conversation
This is just a PoC right now, will fix the warnings etc. if this can get merged in one way or another. What do you think about this approach? I couldn't find a way to reset file permissions to default on unixy systems after having This would fix my problem with #30, as I'd like to persist the temporary files to normal files after being done writing to them. |
Sounds reasonable. However, I'd rather accept an |
Hm. There doesn't seem to be a way to open a file with a given |
Gah. I keep not posting my replies. You're absolutely correct, that's unfortunate. |
So, thinking about this, I'm fine with this approach. I'd rather have a more general approach but... the only API this touches is the builder. Given that, I'm fine going ahead with this. |
Fixed warnings, added some documentation, added a test. |
d5f5a30
to
6c169c1
Compare
Yay, now even compiles on Windows. It's good to go from my side now. :) |
This is still going to need Windows and, preferably, directory support. |
Any progress on this? I want this feature too. @tbu- Do you mind if I work on a new pull request? |
@quark-zju Feel free to redo this. :) |
Cross-referencing from #114: on Linux though it would be helpful to be able to pass a proper |
Fixed in #273. |
Fixes #30.