Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File persisted with 600 permissions #157

Closed
MarinPostma opened this issue Dec 1, 2021 · 4 comments
Closed

File persisted with 600 permissions #157

MarinPostma opened this issue Dec 1, 2021 · 4 comments

Comments

@MarinPostma
Copy link

I have noticed that the permission of a persisted NamedTempFile is 600, but I was expecting it to be 644 (default permissions when creating a file).

I could be mistaken, but i found no mention of that in the doc? Maybe this could be part of the persist documentation?

I can issue a PR if needed.

@Stebalien
Copy link
Owner

Stebalien commented Dec 1, 2021 via email

@assarbad
Copy link

@Stebalien do you know where to find said patch? Perhaps there's a way to make it cross-platform.

@Stebalien
Copy link
Owner

@assarbad #61

@Stebalien
Copy link
Owner

We can now set default permissions (Builder::permissions), so I'll consider this fixed.

acheronfail added a commit to acheronfail/repgrep that referenced this issue Apr 19, 2024
The solution doesn't really make our code any better anyway, so just
leaving the current behaviour as is.
acheronfail added a commit to acheronfail/repgrep that referenced this issue Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants