XGBoostLSSRegressor - Scikit Learn API #66
Replies: 13 comments 2 replies
-
@joshdunnlime Thanks for the interest in the project. An extension to scikit-learn or sktime is on the to-do, but I won't find the time for that. Very happy if you volunteer for this! |
Beta Was this translation helpful? Give feedback.
-
Amazing. I'm very happy to start looking into and hopefully start a PR. It would be good to get some input on naming conventions and over all design when I get there. |
Beta Was this translation helpful? Give feedback.
-
Sure let's align on this. |
Beta Was this translation helpful? Give feedback.
-
I just want to add my support for this. This would dramatically increase the ease of use for this package. |
Beta Was this translation helpful? Give feedback.
-
I've made the first few commits and added the first PR #68. Most of the code is taken from the XGBoost Sklearn package and adapted. I think it makes sense to align with that as closely as possible. There are a few feature that I haven't preserved fully.
|
Beta Was this translation helpful? Give feedback.
-
Any comments or reviews on this? I plan to pick this up again this week |
Beta Was this translation helpful? Give feedback.
-
Thanks for the PR. I am still on vacation and haven't had the time to look into it so far. Please continue. |
Beta Was this translation helpful? Give feedback.
-
@joshdunnlime skpro is a good motivation for having a scikit learn api. |
Beta Was this translation helpful? Give feedback.
-
Funnily enough, I scheduled some time this evening to pick this back up. I've now push a new PR. I think it is close to being ready to review and merge. |
Beta Was this translation helpful? Give feedback.
-
Additionally, there is an ongoing discussion on sklearn about how probabilistic predictions are made in an sklearn context. An agreed API here would be an excellent thing to adopt but for now I have followed XGBLSS's predict methodology. scikit-learn/scikit-learn#23334 |
Beta Was this translation helpful? Give feedback.
-
It also integrates fully with Opened issue with suggestion on integration here: #69 |
Beta Was this translation helpful? Give feedback.
-
I have added separate branches to intergrate the project to the respective frameworks: This allows us to have the different versions separate from the current master-branch. Once the integrations are done we can merge them to master. @joshdunnlime Can you please move the PR to the new branch, thanks. |
Beta Was this translation helpful? Give feedback.
-
@StatMixedML my understanding is that simply adding the sklearn API will allow skpro to utilise xgblss (with some small changes on the skpro side). This in turn will allow sktime to use xgblss. Most of the work is to add missing xgblss distributions in skpro/sktime side as detailed in #69. In the meantime, any not implemented could simply have a In addition, the xgblss native predict api could be extended to accommodate the I will shift my branch to the new branch and add a PR. |
Beta Was this translation helpful? Give feedback.
-
Is there an appetite to add a scikit learn API for this? If so, very happy to help contrib. Also for LightGBMLSS.
Beta Was this translation helpful? Give feedback.
All reactions