Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agnostic schema validator #3

Open
Th3Whit3Wolf opened this issue Jan 17, 2023 · 1 comment
Open

Agnostic schema validator #3

Th3Whit3Wolf opened this issue Jan 17, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@Th3Whit3Wolf
Copy link

Describe your feature request
I would prefer to use typia over zod because it is a smaller package and performs much faster type validation.

Are you willing to contribute this feature?
Yes, with direction on how to best incorporate this into the package.

Related pull request (if applicable)
not yet

@Th3Whit3Wolf Th3Whit3Wolf added the enhancement New feature or request label Jan 17, 2023
@macjuul
Copy link
Member

macjuul commented Jan 17, 2023

Thanks for your suggestion!

This would be difficult to support in the current setup of Cirql. I do like the idea of supporting multiple validation/typing libraries, though.

I might consider splitting Cirql up in multiple packages allowing the validation layer to be swapped out. As long as a library supports both validation and type casting it should be feasible.

I'll revisit this idea when Cirql has progressed a bit further

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants