Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] fix compression context pool slow down after long running (backport #53172) #53231

Merged
merged 1 commit into from
Nov 27, 2024
Merged

[BugFix] fix compression context pool slow down after long running (backport #53172) #53231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion be/src/util/compression/compression_context_pool.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,14 +114,16 @@ class CompressionContextPool {

private:
void add(InternalRef ptr) {
// Use explicit producer token to avoid the overhead of too many sub-queues
static thread_local ::moodycamel::ProducerToken producer_token(_ctx_resources);
DCHECK(ptr);
Status status = _resetter(ptr.get());
// if reset fail, then delete this context
if (!status.ok()) {
return;
}

_ctx_resources.enqueue(std::move(ptr));
_ctx_resources.enqueue(producer_token, std::move(ptr));
}

Creator _creator;
Expand Down
17 changes: 17 additions & 0 deletions be/test/util/block_compression_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
#include <thread>

#include "gen_cpp/segment.pb.h"
#include "util/compression/compression_context_pool_singletons.h"
#include "util/faststring.h"
#include "util/random.h"
#include "util/raw_container.h"
Expand Down Expand Up @@ -386,6 +387,22 @@ TEST_F(BlockCompressionTest, LZ4F_compression_LARGE_PAGE_TEST) {
ASSERT_TRUE(st.ok());
}

TEST_F(BlockCompressionTest, test_multi_thread_get_ctx) {
for (int j = 0; j < 10; j++) {
std::vector<std::thread> workers;
for (int cnt = 0; cnt < 30; cnt++) {
workers.emplace_back([]() {
for (uint64_t i = 1; i < 1000; i++) {
StatusOr<compression::LZ4F_CCtx_Pool::Ref> ref = compression::getLZ4F_CCtx();
}
});
}
for (auto& worker : workers) {
worker.join();
}
}
}

//#define LZ4_BENCHMARK
//#define LZ4F_BENCHMARK
//#define ZSTD_BENCHMARK
Expand Down
Loading