-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] Fix tablet scheduler exception #52925
Merged
wanpengfei-git
merged 2 commits into
StarRocks:main
from
sevev:fix_fe_scheduler_exception
Nov 25, 2024
Merged
[BugFix] Fix tablet scheduler exception #52925
wanpengfei-git
merged 2 commits into
StarRocks:main
from
sevev:fix_fe_scheduler_exception
Nov 25, 2024
+10
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sevev <[email protected]>
fe/fe-core/src/main/java/com/starrocks/clone/TabletScheduler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: sevev <[email protected]>
Quality Gate passedIssues Measures |
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]❌ fail : 3 / 7 (42.86%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
gengjun-git
approved these changes
Nov 20, 2024
HangyuanLiu
approved these changes
Nov 25, 2024
@Mergifyio backport branch-3.3 |
@Mergifyio backport branch-3.2 |
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 25, 2024
Signed-off-by: sevev <[email protected]> (cherry picked from commit 18dba0c)
42 tasks
mergify bot
pushed a commit
that referenced
this pull request
Nov 25, 2024
Signed-off-by: sevev <[email protected]> (cherry picked from commit 18dba0c)
42 tasks
@mergify backport branch-3.4 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 25, 2024
Signed-off-by: sevev <[email protected]> (cherry picked from commit 18dba0c)
42 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
If
TabletScheduler
encountered an unhandled exception when scheduling pending tablets, it only removed the task but did not remove the task_ctx. Consequently, subsequent scheduling will ignore these tablets, and clone and other tasks will no longer be triggered, ultimately causing the alter task to stall.e.g
What I'm doing:
Catch the exception and remove the tablet_ctx.
Fixes https://github.com/StarRocks/StarRocksTest/issues/8829
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: